using 'Content-Disposition: filename=' with files with spaces

When people download from AV, they code i use is:

header("Content-Type: application/octet-stream");
header("Content-Disposition: attachment; filename=$filename");
echo(file_get_contents("uploads/$filename"));

If the filename has a space in it, the first part gets used.

Example:
File1 = spoon and knife.zip = spoon
File2 = spoonandknife.zip = spoonandknife.zip

What didly bits " ' ’ ` do i use to make use the full name?

You should urlencode() the name before you print it. Spaces and a lot of other characters aren't allowed in URLs, they should be replaced by codes such as %20 for the space.

I tryed:

$filename = urlencode($filename);
header("Content-Type: application/octet-stream");
header("Content-Disposition: attachment; filename=$filename");
echo(file_get_contents("uploads/$filename"));

and the out put was:
File1 = spoon and knife.zip = spoon+and+knife.zip
The file "spoon+and+knife.zip" dose not exist, so that did not work.


I just tryed
$filename = str_replace(" ", "%20", $filename);
and it came out as:
File1 = spoon and knife.zip = spoon%20and%20knife.zip
The file "spoon%20and%20knife.zip" dose not exist, so that did not work either.


Any other ideas?

I hope you've already solved the problem...
I think the code should be something like:

[codebox]$filename_enc = urlencode($filename);
header("Content-Type: application/octet-stream");
header("Content-Disposition: attachment; filename=$filename_enc");
echo(file_get_contents("uploads/$filename"));[/codebox]

I hope it works.

What's up with all the guest-necromancing lately

I hope you've already solved the problem...
I think the code should be something like:

$filename_enc = urlencode($filename);header("Content-Type: application/octet-stream");header("Content-Disposition: attachment; filename=$filename_enc");echo(file_get_contents("uploads/$filename"));

I hope it works.

No, this does not work... but...

//Select the Browserfunction detect_browser($var){	if(eregi("(msie) ([0-9]{1,2}.[0-9]{1,3})", $var)){		$c = "ie"; 	}else{		$c = "nn"; 	}	return $c;}Header("Content-Description: File Transfer");if(detect_browser($HTTP_USER_AGENT) == "ie"){	Header("Content-type: application/force-download");}else{	Header("Content-Type: application/octet-stream");}//The only thing that is needed is "" which specifies that it is a complete sentenceHeader('Content-Disposition: attachment; filename="'.$filename'"');$n1= fopen($filename, 'r');while (!feof($n1)){	echo fgets($n1, 512);}fclose($n1);

It works, I have checked

thanks anyway, You helps me fix it

I hope you've already solved the problem...
I think the code should be something like:

$filename_enc = urlencode($filename);header("Content-Type: application/octet-stream");header("Content-Disposition: attachment; filename=$filename_enc");echo(file_get_contents("uploads/$filename"));

I hope it works.

No, this does not work... but...

//Select the Browserfunction detect_browser($var){	if(eregi("(msie) ([0-9]{1,2}.[0-9]{1,3})", $var)){		$c = "ie"; 	}else{		$c = "nn"; 	}	return $c;}Header("Content-Description: File Transfer");if(detect_browser($HTTP_USER_AGENT) == "ie"){	Header("Content-type: application/force-download");}else{	Header("Content-Type: application/octet-stream");}//The only thing that is needed is "" which specifies that it is a complete sentenceHeader('Content-Disposition: attachment; filename="'.$filename'"');$n1= fopen($filename, 'r');while (!feof($n1)){	echo fgets($n1, 512);}fclose($n1);

It works, I have checked

thanks anyway, You helps me fix it

There was an error here (one dot was missing)

Header('Content-Disposition: attachment; filename="'.$filename.'"');

now it works.
Thanks

Try wrapping the filename in double quotes.

header("Content-Disposition: attachment; filename=\"$filename\"");