11 replies to this topic

[DeathRay2K]

I'm having some trouble with a download script I cooked up to serve downloads and log the number of them. I have no experience using the file operations with php, as I'm just learning it, but I can't find errors in my script...

Here's the php:

   $add = 1;
    $file = $_GET['file'];
    $current = fopen('downloads/log/' . $file . '.txt', 'r');
    fclose($current);
    $del = fopen('downloads/log/' . $file . '.txt', 'w');
    fclose($del);
    if($current < 1){
   	 $add = 1;}
   	 else{
   	 $add = $current + 1;}
    $fh = fopen('downloads/log/' . $file . '.txt', 'w') or die("unknown");
    fwrite($fh, $add);
    fclose($fh);
    $n = fopen('downloads/log/' . $file . '.txt', 'r');
    fclose($n);

 <b><?php echo $file; ?></b><br>
 	 Your download of <?php echo $file; ?> will begin in five seconds. If it does not, click the link below.<br><br>
 	 <a href="downloads/<?php echo $file; ?>">Download</a><br>
 	 This file has been downloaded <?php echo $n ?> times.

For some reason the end result looks like:

test.zip
Your download of test.zip will begin in five seconds. If it does not, click the link below.

Download
This file has been downloaded Resource id #4 times.

In the log itself the number is always 2...

[Kravvitz]

For one thing you need to use fread() or something.

fopen() returns a file handle, not the contents of the file.

[DeathRay2K]

Thank you very much!
Its working now.

[DCoder]

^What he said, use one of the following:

$counter = intval(fgets($current));

$counter = intval(fread($current, 8)); // 8 characters should be enough for a loooong time

$counter = fscanf($current, '%d');

$counter = intval(file_get_contents('/path/to/file'));

Edited by DCoder, 26 November 2005 - 06:22 AM.

[DeathRay2K]

Well it seems to be working with this code, and I'm slightly worried about messing it up.

   $file = $_GET['file'];
    $log = 'downloads/log/' . $file . '.txt';
    $logfh = fopen('downloads/log/' . $file . '.txt', 'r');
    $current = fread($logfh, filesize($log));
    fclose($logfh);
    $new = $current + 1;
    $del = fopen('downloads/log/' . $file . '.txt', 'w');
    fclose($del);
    $fh = fopen('downloads/log/' . $file . '.txt', 'w');
    fwrite($fh, $new);
    fclose($fh);
    $logread = fopen('downloads/log/' . $file . '.txt', 'r');
    $n = fread($logread, filesize($log));
    fclose($logread);

Do I even need the whole $del segment? Its only there to delete the log's contents, but will $fh do that anyways?

Edited by DeathRay2K, 26 November 2005 - 06:40 AM.

[DCoder]

If your host supports PHP 5, you can crop all that down to

$fn = '/path/to/file';
 $num = intval(file_get_contents($fn));
 $num++;
 file_put_contents($fn,$num);

And $num will contain the counter value for when you want to output it.
PHP says file_*_contents is much faster than fopen fread fclose.

[DeathRay2K]

Unfortunately my host doesn't support PHP5.
That was the first thing I tried, but it didn't work.

[DeathRay2K]

Well, I thought I had it sorted, but now I have new problems. The code is adding 2 every time, and I can't figure out why.

  	$log = $dir . '/log/' . $file . '.txt';            	//The location of the log file, as $log
  	if(file_exists($log)){
    $logfh = fopen($log, 'r');          //Creates a filehandle called $logfh
    $current = fread($logfh, filesize($log));            	//$current gets the contents of the current log for the specified file
    fclose($logfh);                    //Close the $logfh filehandle
  	}
  	else{
    $current = 0;
  	}

  	$new = $current + 1;                  //Adds 1 to $current a $new

  	$fh = fopen($log, 'w');          //A new filehandle for writing a new log
  	fwrite($fh, $new);                  	//Write $new into the log
  	fclose($fh);                    //Close the filehandle for writing the new log
  	$logread = fopen($log, 'r');        	//New filehandle called $logread for reading the end result of the log
  	$n = fread($logread, filesize($log));              //This actually reads the new log as $n
  	fclose($logread);                  	//Close the $logread filehandle

All it does is read the log, add 1 to it, and write it back into the log...

Edited by DeathRay2K, 05 January 2006 - 06:23 PM.

[DCoder]

You wouldn't happen to be calling that twice per page by any chance?

Btw, function_exists() is a pretty useful tool to simulate file_get/put_contents from PHP 5 and whatnot Right now, your code seems quite repetitive with all those reads/writes IMHO.

if(!function_exists('file_get_contents'))
{
 function file_get_contents($fname)
 {
  // function body goes here
 }
}

P.S. some of those are pretty useless comments... Comments should explain the tricky parts of the code, not every single line.

[DeathRay2K]

LOL! All those comments would make a good example for 'how not to code'...

$new = $current + 1;                  //Adds 1 to $current a $new

Classic!

Yeah, I know, and now its really hard to do anything with it...:DE012: I'm going to remake it once I get my website running on PHP5, but in the meantime, do you have any suggesstions?
That part of the code I've actually already changed.

Edited by DeathRay2K, 06 January 2006 - 02:41 PM.

[DeathRay2K]

Sorry for the double post, but I have switched to a server that supports PHP5! So, I'm going to start from scratch using much improved code.
(And no, I wasn't calling that twice per page. )

Edited by DeathRay2K, 09 January 2006 - 12:43 PM.