Jump to content


Photo

Code cleanup


  • Please log in to reply
2 replies to this topic

#1 LarkinVB

LarkinVB

    title available

  • Members
  • 1,488 posts

Posted 10 May 2006 - 06:37 AM

I'd like to see some code cleanup.

Remove all useless variables like attack_rating, stop_attack_rating etc.
Simplify variables which do use the scale.
We have MinArmyStrengthPerTier but also min_units which basically transfers to min_units * 250. Therefore min_units should be changed to min_army.

When I did the transition to 1.75 I wasted some time tweaking variables which aren't used at all.

You get the idea.

#2 LarkinVB

LarkinVB

    title available

  • Members
  • 1,488 posts

Posted 19 May 2006 - 08:26 AM

More code cleanup :

Please outsource the force tech time from core to loader.ai GetInfo(sType)

Please use the outsourced "TurretPower" value for the various calculations where the core code still adds fixed +300 to army for buildings with weapons.

#3 ArkhanTheBlack

ArkhanTheBlack

    title available

  • Members
  • 814 posts

Posted 19 May 2006 - 12:29 PM

Okay! Will change that for next beta.




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users