I just did all that and it still wouldn't connect. Here's what I did to fix it.
Fix "Couldn't connect to Generals Zero Hour online"
- Uninstall Generals and Zero Hour
- Uninstall Origins
- Uninstall Gen Tool
- Uninstall C&C Online
- Delete all your Command and Conquer folders/ files in your documents folder (C:\Users\User\Documents\Command and Conquer Generals Data etc.)
- Re-Install Origins
- Re-Install Generals and Zero Hour
- Re-Install Gen Tool (latest version)
- Re-Install C&C Online (latest version)
After all this Hook Zero Hour/Generals then run your regular shortcut as administrator. Hit Zero Hour until it brings the game up, use your revora email and c&c password and login.
Works 100% for me now.