The problem you have is "Could not Connect to C&C Generals Zero Hour Online", is that correct?
Using Generals on Windows Vista/7/8/10 can cause connection issues. Run the game as Administrator and in Windows XP compatibility mode to avoid issues. Also check your Online IP in the Options menu of the game. You must select the IP Address of your Internet Adapter.